test: add spec-driven universal CLI suite; fix context strict + path confinement bugs
- tests-universal/ drives repoctl only as a subprocess CLI, asserting
directly against docs/specification.md (envelope, exit codes 0-5,
validation rules MVP, security invariants) so the same suite can judge
any conforming implementation, including the sibling codex/repoctl-l1
branch built independently from the same baseline.
- Running it surfaced two real bugs, both fixed:
- `context --strict` only checked budget truncation, never stale or
missing referenced documents, despite specification.md 19.2 defining
exit 4 as "stale or incomplete context" (not just truncation).
- `paths.confined_path` crashed with an unhandled WinError2 when a
referenced path's parent directory also didn't exist, because it
resolved a single non-existent parent with strict=True instead of
walking up to the nearest existing ancestor.
This commit is contained in:
@@ -128,7 +128,7 @@ def cmd_context(args: argparse.Namespace) -> int:
|
||||
]
|
||||
outcome = "success"
|
||||
exit_code = EXIT_SUCCESS
|
||||
if result.truncated and args.strict:
|
||||
if (result.truncated or result.incomplete) and args.strict:
|
||||
outcome = "failure"
|
||||
exit_code = EXIT_STRICT_INCOMPLETE
|
||||
_write(build_envelope("context", outcome, data, findings), args.output)
|
||||
|
||||
Reference in New Issue
Block a user